From jrd at gerdesas.com Tue Jun 3 14:32:47 2008 From: jrd at gerdesas.com (John R. Dennison) Date: Tue, 3 Jun 2008 14:32:47 -0500 Subject: [netrek-dev] netrek dev wiki In-Reply-To: <20080530201713.GL10889@mail.beanhq.com> References: <20080530201713.GL10889@mail.beanhq.com> Message-ID: <20080603193247.GN10889@mail.beanhq.com> On Fri, May 30, 2008 at 03:17:13PM -0500, John R. Dennison wrote: > There are python errors in the dev wiki at: > > http://wiki.us.netrek.org/netrek-dev > > Is this residual from last night? I just noticed that the problems with the dev wiki have been resolved sometime in the past 2 hours. Thank you to whomever was responsible. John -- "I'm sorry but our engineers do not have phones." As stated by a Network Solutions Customer Service representative when asked to be put through to an engineer. "My other computer is your windows box." Ralf Hildebrandt trying to play sturgeon while it's under attack is apparently not fun. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available Url : http://mailman.us.netrek.org/pipermail/netrek-dev/attachments/20080603/803b049a/attachment.pgp From jrd at gerdesas.com Tue Jun 3 16:28:13 2008 From: jrd at gerdesas.com (John R. Dennison) Date: Tue, 3 Jun 2008 16:28:13 -0500 Subject: [netrek-dev] netrek dev wiki In-Reply-To: <20080603193247.GN10889@mail.beanhq.com> References: <20080530201713.GL10889@mail.beanhq.com> <20080603193247.GN10889@mail.beanhq.com> Message-ID: <20080603212813.GO10889@mail.beanhq.com> On Tue, Jun 03, 2008 at 02:32:47PM -0500, John R. Dennison wrote: > On Fri, May 30, 2008 at 03:17:13PM -0500, John R. Dennison wrote: > > There are python errors in the dev wiki at: > > > > http://wiki.us.netrek.org/netrek-dev > > > > Is this residual from last night? > > I just noticed that the problems with the dev wiki have been > resolved sometime in the past 2 hours. > > Thank you to whomever was responsible. Well, it appears I jumped the gun. I had only lynx'd the first page and noticed it was back on-line; sadly it appears that content is missing (missing links, no recent changes listed, etc). John -- "I'm sorry but our engineers do not have phones." As stated by a Network Solutions Customer Service representative when asked to be put through to an engineer. "My other computer is your windows box." Ralf Hildebrandt trying to play sturgeon while it's under attack is apparently not fun. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available Url : http://mailman.us.netrek.org/pipermail/netrek-dev/attachments/20080603/c273c909/attachment.pgp From quozl at us.netrek.org Tue Jun 3 18:04:56 2008 From: quozl at us.netrek.org (James Cameron) Date: Wed, 4 Jun 2008 09:04:56 +1000 Subject: [netrek-dev] netrek dev wiki In-Reply-To: <20080603212813.GO10889@mail.beanhq.com> References: <20080530201713.GL10889@mail.beanhq.com> <20080603193247.GN10889@mail.beanhq.com> <20080603212813.GO10889@mail.beanhq.com> Message-ID: <20080603230456.GB6321@us.netrek.org> Bob worked on it, and let me know progress, asked for testing ... I've tested, confirming your diagnosis, and I've let him know through the request tracker that he's got some more things to fix. -- James Cameron mailto:quozl at us.netrek.org http://quozl.netrek.org/ From akb+lists.netrek-dev at mirror.to Wed Jun 4 16:02:11 2008 From: akb+lists.netrek-dev at mirror.to (Andrew K. Bressen) Date: Wed, 04 Jun 2008 17:02:11 -0400 Subject: [netrek-dev] outage In-Reply-To: <20080530200405.GK10889@mail.beanhq.com> (John R. Dennison's message of "Fri, 30 May 2008 15:04:05 -0500") References: <0qlk1swai9.fsf@lanconius.mirror.to> <20080530074148.GJ10889@mail.beanhq.com> <0q63svwolh.fsf@lanconius.mirror.to> <20080530200405.GK10889@mail.beanhq.com> Message-ID: <0qzlq0rk18.fsf@lanconius.mirror.to> "John R. Dennison" writes: > Having the primary portal to netrek unavailable for multiple > hours is not doing anyone any good. No, but a few hours a year of downtime, even a couple of days per year of downtime, aren't doing a whole lot of harm, either. I really think 99% (<3.65 days/year downtime) is adequate for our uses; I think that this is a KISS scenario. --akb ps: it appears the dev wiki is restored. From quozl at us.netrek.org Wed Jun 4 17:30:33 2008 From: quozl at us.netrek.org (James Cameron) Date: Thu, 5 Jun 2008 08:30:33 +1000 Subject: [netrek-dev] outage In-Reply-To: <0qzlq0rk18.fsf@lanconius.mirror.to> References: <0qlk1swai9.fsf@lanconius.mirror.to> <20080530074148.GJ10889@mail.beanhq.com> <0q63svwolh.fsf@lanconius.mirror.to> <20080530200405.GK10889@mail.beanhq.com> <0qzlq0rk18.fsf@lanconius.mirror.to> Message-ID: <20080604223033.GA6804@us.netrek.org> On Wed, Jun 04, 2008 at 05:02:11PM -0400, Andrew K. Bressen wrote: > ps: it appears the dev wiki is restored. Yes, version upgrade, has a few little problems though, some markup will need to change ... I haven't figured everything out yet. Additional editors are welcome. The link syntax has changed, [[Page_Name]] instead of [Page Name] for example. See FrontPage for other examples. -- James Cameron mailto:quozl at us.netrek.org http://quozl.netrek.org/ From jrd at gerdesas.com Wed Jun 4 17:35:07 2008 From: jrd at gerdesas.com (John R. Dennison) Date: Wed, 4 Jun 2008 17:35:07 -0500 Subject: [netrek-dev] outage In-Reply-To: <20080604223033.GA6804@us.netrek.org> References: <0qlk1swai9.fsf@lanconius.mirror.to> <20080530074148.GJ10889@mail.beanhq.com> <0q63svwolh.fsf@lanconius.mirror.to> <20080530200405.GK10889@mail.beanhq.com> <0qzlq0rk18.fsf@lanconius.mirror.to> <20080604223033.GA6804@us.netrek.org> Message-ID: <20080604223506.GP10889@mail.beanhq.com> On Thu, Jun 05, 2008 at 08:30:33AM +1000, James Cameron wrote: > On Wed, Jun 04, 2008 at 05:02:11PM -0400, Andrew K. Bressen wrote: > > ps: it appears the dev wiki is restored. > > Yes, version upgrade, has a few little problems though, some markup will > need to change ... I haven't figured everything out yet. Additional > editors are welcome. Add me as an editor :) John -- "I'm sorry but our engineers do not have phones." As stated by a Network Solutions Customer Service representative when asked to be put through to an engineer. "My other computer is your windows box." Ralf Hildebrandt trying to play sturgeon while it's under attack is apparently not fun. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available Url : http://mailman.us.netrek.org/pipermail/netrek-dev/attachments/20080604/4772737e/attachment.pgp From jrd at gerdesas.com Fri Jun 6 23:17:51 2008 From: jrd at gerdesas.com (John R. Dennison) Date: Fri, 6 Jun 2008 23:17:51 -0500 Subject: [netrek-dev] My repo has moved Message-ID: <20080607041751.GJ8143@mail.beanhq.com> I have moved my darcs repo to an external host: http://darcs.gerdesas.com/netrek-server/ I will leave the old repo on-line and sync'd for a week or so and then deactivate it. John -- "I'm sorry but our engineers do not have phones." As stated by a Network Solutions Customer Service representative when asked to be put through to an engineer. "My other computer is your windows box." Ralf Hildebrandt trying to play sturgeon while it's under attack is apparently not fun. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available Url : http://mailman.us.netrek.org/pipermail/netrek-dev/attachments/20080606/276c1178/attachment.pgp From jrd at gerdesas.com Fri Jun 6 23:43:52 2008 From: jrd at gerdesas.com (John R. Dennison) Date: Fri, 6 Jun 2008 23:43:52 -0500 Subject: [netrek-dev] netrek-client-cow mirror Message-ID: <20080607044352.GK8143@mail.beanhq.com> I've added a mirror that is synced from James' for the linux COW client at http://darcs.gerdesas.com/netrek-client-cow. John -- "I'm sorry but our engineers do not have phones." As stated by a Network Solutions Customer Service representative when asked to be put through to an engineer. "My other computer is your windows box." Ralf Hildebrandt trying to play sturgeon while it's under attack is apparently not fun. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available Url : http://mailman.us.netrek.org/pipermail/netrek-dev/attachments/20080606/398034e6/attachment.pgp From quozl at us.netrek.org Thu Jun 12 03:32:25 2008 From: quozl at us.netrek.org (James Cameron) Date: Thu, 12 Jun 2008 18:32:25 +1000 Subject: [netrek-dev] netrek-client-pygame, added UDP Message-ID: <20080612083225.GA26787@us.netrek.org> UDP mode is now added, and further work on the quit mystery done. -- James Cameron mailto:quozl at us.netrek.org http://quozl.netrek.org/ From akb+lists.netrek-dev at mirror.to Fri Jun 13 00:18:06 2008 From: akb+lists.netrek-dev at mirror.to (Andrew K. Bressen) Date: Fri, 13 Jun 2008 01:18:06 -0400 Subject: [netrek-dev] sourceforge awards Message-ID: <0q4p7xkj5d.fsf@lanconius.mirror.to> Sourceforge.net is sponsoring awards for open source software in a bunch of categories. Users nominate software, ten finalists per category are chosen, and then I guess there's a vote for the winner. I've nominated Netrek for "best project for gamers", I used the url http://www.netrek.org and name "Netrek" If you have a sourceforge account or an OpenID account, please go nominate us. If not, create an account and nominate us! The url for nominations is http://sourceforge.net/community/wp-content/uploads/2008/06/nominate.html I'll probably add the nomination badge link to the web pages. --akb From netrek at gmail.com Mon Jun 16 01:20:56 2008 From: netrek at gmail.com (Zach) Date: Mon, 16 Jun 2008 02:20:56 -0400 Subject: [netrek-dev] sourceforge awards In-Reply-To: <0q4p7xkj5d.fsf@lanconius.mirror.to> References: <0q4p7xkj5d.fsf@lanconius.mirror.to> Message-ID: Here is the badge HTML code snippet: Zach From joe at romulus.netrek.org Wed Jun 18 11:12:14 2008 From: joe at romulus.netrek.org (Joe Evango) Date: Wed, 18 Jun 2008 11:12:14 -0500 Subject: [netrek-dev] FW: Support Request In-Reply-To: <000501c8d14a$5346e7c0$f9d4b740$@k12.ny.us> References: <000501c8d14a$5346e7c0$f9d4b740$@k12.ny.us> Message-ID: Can anyone help this person finish setting up his Netrek server? He is the Director of the Academy of Information Technology in New York. Based on his request his server appears to not be open to the public and is only available to the students at his high school. This might be a very good opportunity to get some new players interested in the game. His server is up but his students can only login as guest. His request and contact information are below. Thanks, Joe From: wclaps at northport.k12.ny.us To: support at playnetrek.org Subject: Support Request Date: Wed, 18 Jun 2008 09:50:53 -0400 To whom it may concern: I?m setting up a netrek server at the request of some of my students. I have the server set up using the latest repo and everything is fine. However, the students can only login and play as guests. Any attempt to create a user when the connect to the sever results in a bad password comment. I?m beginning to think this is a permissions issue. I have spend a god 4 hours trying to find an answer to this online. Sorry if this question has been asked before. Thanks for any help you can provide. Bill Claps Director - Academy of Information Technology Northport High School 154 Laurel Hill Road Northport, New York 11768 email: wclaps at northport.k12.ny.us web page: http://www.northport.k12.ny.us/aoit _________________________________________________________________ The i?m Talkathon starts 6/24/08.? For now, give amongst yourselves. http://www.imtalkathon.com?source=TXT_EML_WLH_LearnMore_GiveAmongst -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mailman.us.netrek.org/pipermail/netrek-dev/attachments/20080618/0aabebee/attachment.htm From jrd at gerdesas.com Wed Jun 18 13:20:02 2008 From: jrd at gerdesas.com (John R. Dennison) Date: Wed, 18 Jun 2008 13:20:02 -0500 Subject: [netrek-dev] FW: Support Request In-Reply-To: References: <000501c8d14a$5346e7c0$f9d4b740$@k12.ny.us> Message-ID: <20080618182001.GL2596@frodo.gerdesas.com> On Wed, Jun 18, 2008 at 11:12:14AM -0500, Joe Evango forward to netrek-dev: > I?m setting up a netrek server at the request of some of > my students. I have the server set up using the latest repo and > everything is fine. What platform, OS and version are you compiling on? Where did you pull the latest repo from? > However, the students can only login and play as guests. Any attempt > to create > a user when the connect to the sever results in a bad password comment. I?m > beginning to think this is a permissions issue. I have spend a god 4 hours > trying to find an answer to this online. Sorry if this question has > been asked > before. Thanks for any help you can provide. * Double check permissions on the following paths: /path/to/netrek/var /path/to/netrek/var/players /path/to/netrek/var/players.index All should be writable as the uid the server is running under. * Modify your etc/sysdef and set ERROR_LEVEL to 9, this will display data pertinent to the password verification step. I saw an odd issue of crypt(3) on a 64bit install of linux a few months back and can't quite recall the details of it at the moment. Increasing the debugging level should point it out, though. The server will need to be restarted for this change to take effect. Debugging output will be in /path/to/netrek/var/ERRORS. * As a test to rule out problems with GDBM indexing of the var/players file, re-compile with player file indexing disabled. You can do this by modifying the config.h file that resides in the includes/ directory of the netrek source tree and changing "#define PLAYER_INDEXING" to "#undef PLAYER_INDEXING", re-building and re-installing, and re-starting when done. Note you will probably have to stop the server before the make install step. Try these steps first and let us know the results. If you wish you may contact me directly or just respond back to the netrek-dev mailing list. John -- "I'm sorry but our engineers do not have phones." As stated by a Network Solutions Customer Service representative when asked to be put through to an engineer. "My other computer is your windows box." Ralf Hildebrandt trying to play sturgeon while it's under attack is apparently not fun. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available Url : http://mailman.us.netrek.org/pipermail/netrek-dev/attachments/20080618/5958e7bb/attachment.pgp From jrd at gerdesas.com Wed Jun 18 16:08:59 2008 From: jrd at gerdesas.com (John R. Dennison) Date: Wed, 18 Jun 2008 16:08:59 -0500 Subject: [netrek-dev] FW: Support Request In-Reply-To: References: <000501c8d14a$5346e7c0$f9d4b740$@k12.ny.us> Message-ID: <20080618210859.GO2596@frodo.gerdesas.com> On Wed, Jun 18, 2008 at 11:12:14AM -0500, Joe Evango wrote: > > Can anyone help this person finish setting up his Netrek server? I am in communication with Bill now. John -- "I'm sorry but our engineers do not have phones." As stated by a Network Solutions Customer Service representative when asked to be put through to an engineer. "My other computer is your windows box." Ralf Hildebrandt trying to play sturgeon while it's under attack is apparently not fun. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available Url : http://mailman.us.netrek.org/pipermail/netrek-dev/attachments/20080618/62ec0c7d/attachment.pgp From jrd at gerdesas.com Thu Jun 19 17:58:39 2008 From: jrd at gerdesas.com (John R. Dennison) Date: Thu, 19 Jun 2008 17:58:39 -0500 Subject: [netrek-dev] [wclaps@northport.k12.ny.us: RE: FW: Support Request] Message-ID: <20080619225839.GT2596@frodo.gerdesas.com> He is up and running. Will suggest he run the server as another user other than root. John ----- Forwarded message from William Claps ----- > Date: Thu, 19 Jun 2008 16:13:05 -0400 > From: "William Claps" > To: "'John R. Dennison'" > Subject: RE: [netrek-dev] FW: Support Request > > Success!!! > > However, some interesting things happened that may prove useful the next > time an idiot like me contacts you for help. First, when I finished > compiling from source as you told me, it seems that apt did not remove the > old installation and there was a big mess. No problem, I fixed that. Once I > was finished redoing everything, I went to start the daemon but did not > issue the sudo command. Since you probably work as root configuring a > CentOS box, this would not be a problem. However, in Ubuntu there is no > root unless you create one. So....I believe that this prevented the > creation of the "players" file and therefore prevent me from creating a new > user. What do you think? Anyway....Problem solved...I'm listening to > Shatner as I type this message. > > Thanks John. Let me know if I can return the favor one day. > > Bill > > -----Original Message----- > From: John R. Dennison [mailto:jrd at gerdesas.com] > Sent: Thursday, June 19, 2008 1:35 PM > To: William Claps > Subject: Re: [netrek-dev] FW: Support Request > > On Thu, Jun 19, 2008 at 11:40:54AM -0400, William Claps wrote: > > Wow John. I have never received such complete instructions before. > > Thank you for all of your time and effort. > > Many years of providing support :) > > And you are more than welcome. > > > Darcs installed without a hitch. I used it to download the directory > > to my home directory. I then moved to the Vanilla directory and ran > > "sh ./autogen.sh". And this is what I got: > > > > wclaps at AOIT-S213-Ubuntu:~/netrek-server/Vanilla$ sh ./autogen.sh > > ./autogen.sh: 10: aclocal: not found > > ./autogen.sh: 11: libtoolize: not found > > ./autogen.sh: 12: autoconf: not found > > ./autogen.sh: 13: autoconf: not found > > chmod: cannot access `tools/mktrekon': No such file or directory > > cd: 15: can't cd to tools/admin > > chmod: cannot access `debian/rules': No such file or directory > > chmod: cannot access `debian/postinst': No such file or directory > > chmod: cannot access `debian/postrm': No such file or directory > > chmod: cannot access `debian/netrek-server-vanilla.init': No such file > > or directory > > chmod: cannot access `tests/build': No such file or directory > > autogen.sh completed ok > > You do not have the the following tools installed: > > autoconf > automake > libtool > > I apologize - I had thought that Ubuntu installed them by > default, apparently not :( > > apt-get those, and then try rebuilding again and lets see what > happens. > > > It looks like a permissions error. But, I can't seem to figure out why. > > The files in question are built, I believe, during the > early execution phase of autogen.sh; the installation of > the three packages above should resolve the current issues. > > > > > John > > -- > "I'm sorry but our engineers do not have phones." > As stated by a Network Solutions Customer Service representative when asked > to be put through to an engineer. > > "My other computer is your windows box." > Ralf Hildebrandt trying to play > sturgeon while it's under attack is apparently not fun. > ----- End forwarded message ----- -- "I'm sorry but our engineers do not have phones." As stated by a Network Solutions Customer Service representative when asked to be put through to an engineer. "My other computer is your windows box." Ralf Hildebrandt trying to play sturgeon while it's under attack is apparently not fun. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available Url : http://mailman.us.netrek.org/pipermail/netrek-dev/attachments/20080619/43d77b67/attachment.pgp From quozl at us.netrek.org Fri Jun 20 06:21:20 2008 From: quozl at us.netrek.org (James Cameron) Date: Fri, 20 Jun 2008 21:21:20 +1000 Subject: [netrek-dev] [wclaps@northport.k12.ny.us: RE: FW: Support Request] In-Reply-To: <20080619225839.GT2596@frodo.gerdesas.com> References: <20080619225839.GT2596@frodo.gerdesas.com> Message-ID: <20080620112120.GA30228@us.netrek.org> On Thu, Jun 19, 2008 at 05:58:39PM -0500, John R. Dennison wrote: > He is up and running. Will suggest he run the server as another user > other than root. Have we a problem to fix in the source? Can we include this experience in installation instructions? (In other news, the current version of the pygame client just got a test on an OLPC XO and worked fine. A bit of screen relayout to do.) -- James Cameron mailto:quozl at us.netrek.org http://quozl.netrek.org/ From quozl at us.netrek.org Fri Jun 20 22:11:57 2008 From: quozl at us.netrek.org (James Cameron) Date: Sat, 21 Jun 2008 13:11:57 +1000 Subject: [netrek-dev] [PATCH] SP_BADVERSION, avoid leak, symbolise Message-ID: <20080621031157.GA16095@us.netrek.org> Rework of the SP_BADVERSION packet which is sent to the client if the CP_SOCKET packet contains incorrect protocol version number, or when the queue has no free slots, or when a player is banned, or when a connection is dropped due to netrekd denied IP list. - add symbolic names for the reason codes, - prepare the packet buffer with zeros to avoid data leaks, - document the current state of client processing of reason codes. This patch does not change the behaviour of the server, apart from starting with a packet buffer which is clean. Sat Jun 21 12:59:10 EST 2008 quozl at us.netrek.org * SP_BADVERSION, avoid leak, symbolise diff -rN -u old-netrek-server/Vanilla/include/packets.h new-netrek-server/Vanilla/include/packets.h --- old-netrek-server/Vanilla/include/packets.h 2008-06-21 13:10:57.000000000 +1000 +++ new-netrek-server/Vanilla/include/packets.h 2008-06-21 13:10:57.000000000 +1000 @@ -408,6 +408,18 @@ char pad3; }; +/* numbering and ordering per current usage as at 2008-06-21 */ +#define BADVERSION_SOCKET 0 /* CP_SOCKET version does not match, exiting */ +#define BADVERSION_DENIED 1 /* access denied by netrekd */ +#define BADVERSION_NOSLOT 1 /* no slot on queue */ +#define BADVERSION_BANNED 2 /* banned */ +#define BADVERSION_DOWN 6 /* game shutdown by server */ +#define BADVERSION_SILENCE 6 /* daemon stalled */ +#define BADVERSION_SELECT 6 /* internal error */ +/* as at 2008-06-21 netrek-client-cow and netrek-client-xp report 0 as + invalid version, 1-6 as cannot play, others are not valid, and + netrek-client-xp uses a popup message box for 1-6 */ + struct hostile_spacket { /* SP_HOSTILE py-struct "!bbbb" #22 */ char type; char pnum; diff -rN -u old-netrek-server/Vanilla/newstartd/newstartd.c new-netrek-server/Vanilla/newstartd/newstartd.c --- old-netrek-server/Vanilla/newstartd/newstartd.c 2008-06-21 13:10:57.000000000 +1000 +++ new-netrek-server/Vanilla/newstartd/newstartd.c 2008-06-21 13:10:57.000000000 +1000 @@ -539,8 +539,10 @@ } /* issue a bad version packet to the client */ + memset(&packet, 0, sizeof(struct badversion_spacket)); packet.type = SP_BADVERSION; - packet.why = 1; +#define BADVERSION_DENIED 1 /* access denied by netrekd */ + packet.why = BADVERSION_DENIED; write (0, (char *) &packet, sizeof(packet)); sleep (2); diff -rN -u old-netrek-server/Vanilla/ntserv/input.c new-netrek-server/Vanilla/ntserv/input.c --- old-netrek-server/Vanilla/ntserv/input.c 2008-06-21 13:10:57.000000000 +1000 +++ new-netrek-server/Vanilla/ntserv/input.c 2008-06-21 13:10:57.000000000 +1000 @@ -62,18 +62,19 @@ #endif /*PING*/ } -static void gamedown() +static void gamedown(why) { struct badversion_spacket packet; + memset(&packet, 0, sizeof(struct badversion_spacket)); packet.type = SP_BADVERSION; - packet.why = 6; + packet.why = why; sendClientPacket(&packet); flushSockBuf(); } -static void panic() +static void panic(int why) { - gamedown(); + gamedown(why); freeslot(me); exit(0); } @@ -94,7 +95,7 @@ freeslot(me); exit(0); } - if (!(status -> gameup & GU_GAMEOK)) panic(); + if (!(status -> gameup & GU_GAMEOK)) panic(BADVERSION_DOWN); /* wait for activity on network socket or next daemon update */ while (1) { FD_ZERO(&readfds); @@ -111,10 +112,10 @@ poll.tv_usec = 0; rv = select(nfds+1, &readfds, 0, 0, &poll); if (rv > 0) break; - if (rv == 0) { panic(); /* daemon silence timeout */ } + if (rv == 0) { panic(BADVERSION_SILENCE); /* daemon timeout */ } if (errno == EINTR) continue; perror("select"); - panic(); + panic(BADVERSION_SELECT); } /* if daemon signalled us, perform the update only */ if (FD_ISSET(afd, &readfds)) { diff -rN -u old-netrek-server/Vanilla/ntserv/main.c new-netrek-server/Vanilla/ntserv/main.c --- old-netrek-server/Vanilla/ntserv/main.c 2008-06-21 13:10:57.000000000 +1000 +++ new-netrek-server/Vanilla/ntserv/main.c 2008-06-21 13:10:57.000000000 +1000 @@ -34,7 +34,7 @@ #endif /* file scope prototypes */ -static void noplay(); +static void noplay(int reason); static void reaper(int); static void printUsage(char *prog); static void sendMotd(void); @@ -149,7 +149,7 @@ if (host && ip) { if ((bans_check_permanent(login, host) == TRUE) || (bans_check_permanent(login, ip) == TRUE)) { - noplay(2); + noplay(BADVERSION_BANNED); ERROR(2,("ntserv/main.c: premature disconnect of %s due to permanent ban\n", ip)); exit(1); } @@ -188,7 +188,7 @@ /* wait for a slot to become free */ pno = findslot(w_queue); if (pno < 0) { - noplay(1); + noplay(BADVERSION_NOSLOT); ERROR(2,("ntserv/main.c: Quitting: No slot available on queue %d\n",w_queue)); exit(1); } @@ -420,11 +420,12 @@ } } -void noplay(int reason) +static void noplay(int reason) { /* trigger client's "Sorry, but you cannot play xtrek now. Try again later." */ struct badversion_spacket packet; + memset(&packet, 0, sizeof(struct badversion_spacket)); packet.type = SP_BADVERSION; packet.why = reason; sendClientPacket (&packet); diff -rN -u old-netrek-server/Vanilla/ntserv/socket.c new-netrek-server/Vanilla/ntserv/socket.c --- old-netrek-server/Vanilla/ntserv/socket.c 2008-06-21 13:10:57.000000000 +1000 +++ new-netrek-server/Vanilla/ntserv/socket.c 2008-06-21 13:10:57.000000000 +1000 @@ -1818,8 +1818,9 @@ struct badversion_spacket packet; if (userVersion != SOCKVERSION) { - packet.type=SP_BADVERSION; - packet.why=0; + memset(&packet, 0, sizeof(struct badversion_spacket)); + packet.type = SP_BADVERSION; + packet.why = BADVERSION_SOCKET; sendClientPacket((CVOID) &packet); flushSockBuf(); return 0; -- James Cameron mailto:quozl at us.netrek.org http://quozl.netrek.org/ From quozl at us.netrek.org Fri Jun 20 22:16:10 2008 From: quozl at us.netrek.org (James Cameron) Date: Sat, 21 Jun 2008 13:16:10 +1000 Subject: [netrek-dev] [PATCH] SP_BADVERSION, renumbering Message-ID: <20080621031610.GA16277@us.netrek.org> A renumbering of the SP_BADVERSION reason codes, consistent with current Microsoft Windows and Linux clients. Not yet checked against MacTrek. Sat Jun 21 13:13:16 EST 2008 quozl at us.netrek.org * SP_BADVERSION, renumbering diff -rN -u old-netrek-server/Vanilla/include/packets.h new-netrek-server/Vanilla/include/packets.h --- old-netrek-server/Vanilla/include/packets.h 2008-06-21 13:15:05.000000000 +1000 +++ new-netrek-server/Vanilla/include/packets.h 2008-06-21 13:15:06.000000000 +1000 @@ -408,14 +408,13 @@ char pad3; }; -/* numbering and ordering per current usage as at 2008-06-21 */ -#define BADVERSION_SOCKET 0 /* CP_SOCKET version does not match, exiting */ -#define BADVERSION_DENIED 1 /* access denied by netrekd */ -#define BADVERSION_NOSLOT 1 /* no slot on queue */ -#define BADVERSION_BANNED 2 /* banned */ -#define BADVERSION_DOWN 6 /* game shutdown by server */ -#define BADVERSION_SILENCE 6 /* daemon stalled */ -#define BADVERSION_SELECT 6 /* internal error */ +#define BADVERSION_SOCKET 0 /* CP_SOCKET version does not match, exiting */ +#define BADVERSION_DENIED 1 /* access denied by netrekd */ +#define BADVERSION_NOSLOT 2 /* no slot on queue */ +#define BADVERSION_BANNED 3 /* banned */ +#define BADVERSION_DOWN 4 /* game shutdown by server */ +#define BADVERSION_SILENCE 5 /* daemon stalled */ +#define BADVERSION_SELECT 6 /* internal error */ /* as at 2008-06-21 netrek-client-cow and netrek-client-xp report 0 as invalid version, 1-6 as cannot play, others are not valid, and netrek-client-xp uses a popup message box for 1-6 */ -- James Cameron mailto:quozl at us.netrek.org http://quozl.netrek.org/ From quozl at us.netrek.org Fri Jun 20 22:31:10 2008 From: quozl at us.netrek.org (James Cameron) Date: Sat, 21 Jun 2008 13:31:10 +1000 Subject: [netrek-dev] [PATCH] XP, SP_BADVERSION reporting Message-ID: <20080621033110.GA16532@us.netrek.org> The attached patch to the netrek-client-xp repository adds explanations via message boxes for each SP_BADVERSION reason code. Bill? -- James Cameron mailto:quozl at us.netrek.org http://quozl.netrek.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: sp_badversion_3.patch Type: text/x-diff Size: 2321 bytes Desc: not available Url : http://mailman.us.netrek.org/pipermail/netrek-dev/attachments/20080621/e017a711/attachment.patch From billbalcerski at gmail.com Fri Jun 20 23:58:25 2008 From: billbalcerski at gmail.com (Bill Balcerski) Date: Sat, 21 Jun 2008 00:58:25 -0400 Subject: [netrek-dev] [PATCH] XP, SP_BADVERSION reporting In-Reply-To: <20080621033110.GA16532@us.netrek.org> References: <20080621033110.GA16532@us.netrek.org> Message-ID: <45ab86180806202158m346bbaecv60886b641fcce19f@mail.gmail.com> Will take patch. Quozl: you have my blessing to make commits without review to the netrek-client-xp repository, just let me know when you do so I can run cvs update on my working repository. Any other developer is also welcome to make contributions. Bill On Fri, Jun 20, 2008 at 11:31 PM, James Cameron wrote: > The attached patch to the netrek-client-xp repository adds explanations > via message boxes for each SP_BADVERSION reason code. > > Bill? > > -- > James Cameron mailto:quozl at us.netrek.org http://quozl.netrek.org/ > > _______________________________________________ > netrek-dev mailing list > netrek-dev at us.netrek.org > http://mailman.us.netrek.org/mailman/listinfo/netrek-dev > > From quozl at us.netrek.org Sat Jun 21 02:28:56 2008 From: quozl at us.netrek.org (James Cameron) Date: Sat, 21 Jun 2008 17:28:56 +1000 Subject: [netrek-dev] SP_BADVERSION response in pygame client Message-ID: <20080621072856.GA22140@us.netrek.org> For completeness ... here is what the pygame client has had added ... a set of short explanations for each SP_BADVERSION why value, and then a more detailed diagnosis message for users. s = ['Protocol version in CP_SOCKET is not supported by server.', 'Access denied by server.', 'No free slots on server queue.', 'Banned from server.', 'Game shutdown by server.', 'Server daemon stalled, internal error.', 'Server reports internal error.'] l = [['You have either connected to a server that does not support', 'this client, or the server itself is insane.', '', 'Try a different server,', 'or report this to the server owner,', 'or report this to the client developer.'], ['The server has your IP address, or a range of addresses, in a', 'configuration file, due to a prior denial of service attack.', '', 'Try a different server,', 'or try a different service provider,', 'or ask the server owner about it.'], ['The server was not able to place you in the queue, perhaps', 'due to a denial of service attack happening right now.', '', 'Or if you were in a clue game, the captain has freed your slot', 'so that another play can join.', '', 'Or in a pickup game the players ejected you.', '', 'Try a different server,', 'or rejoin as an observer on the clue game.'], ['The server has your IP address in the list of bans,', 'usually because you were banned by the players or the owner.', '', 'Try a different server,', 'and if you were misbehaving try not to in future.'], ['The server was shutdown by the owner,', 'probably only temporarily.', '', 'Try a different server,', 'or try this server later,', 'or ask the server owner about it.']] http://james.tooraweenah.com/cgi-bin/darcs.cgi/netrek-client-pygame/?c=diff&p=20080621070823-e4f26-66bac7ef3cc715b7b330a472c1ce5617c1c0acb5.gz -- James Cameron mailto:quozl at us.netrek.org http://quozl.netrek.org/ From stephen at thorne.id.au Thu Jun 26 01:54:21 2008 From: stephen at thorne.id.au (Stephen Thorne) Date: Thu, 26 Jun 2008 16:54:21 +1000 (EST) Subject: [netrek-dev] darcs patch: Client and Server packets transition to using metaclas... Message-ID: <20080626065421.4E7D31180703@ip-10-233-11-43.local> Thu Jun 26 16:51:57 EST 2008 Stephen Thorne * Client and Server packets transition to using metaclasses. This is a very complicated patch to simplify the work required to define server and client packets. When a class CP_FOO(CP) is defined, it is automatically put into a lookup table, and also instanciated and put into the namespace as cp_foo. Further work: put all the server and client packets into their own module, and don't do automatic name space polution. Scanned by the NetBox from NetBox Blue (http://netboxblue.com/) -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: text/x-darcs-patch Size: 22587 bytes Desc: A darcs patch for your repository! Url : http://mailman.us.netrek.org/pipermail/netrek-dev/attachments/20080626/7c1c621b/attachment.bin From quozl at us.netrek.org Thu Jun 26 18:55:47 2008 From: quozl at us.netrek.org (James Cameron) Date: Fri, 27 Jun 2008 09:55:47 +1000 Subject: [netrek-dev] security fix, CP_SOCKET, denial of service Message-ID: <20080626235547.GA8493@us.netrek.org> G'day, The attached patch reduces the impact of a denial of service security vulnerability in versions of the Netrek Vanilla Server from 2.14.0 and prior. After receiving CP_SOCKET the server waits an excessive time with a slot allocated. This can lead to a denial of service. The patch reduces this time and allows it to be configured without rebuild. A reproducer is available and has been tested. Client impact: Netrek XP, should work as normal. COW on Linux, will need change from 199 to 99 seconds login timeout. See getname.c. -- James Cameron mailto:quozl at us.netrek.org http://quozl.netrek.org/ -------------- next part -------------- A non-text attachment was scrubbed... Name: netrek-server-vanilla-2.14.0-2008-06-27.patch Type: text/x-diff Size: 4264 bytes Desc: not available Url : http://mailman.us.netrek.org/pipermail/netrek-dev/attachments/20080627/3a6e6c1a/attachment-0001.patch -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: Digital signature Url : http://mailman.us.netrek.org/pipermail/netrek-dev/attachments/20080627/3a6e6c1a/attachment-0001.pgp From quozl at us.netrek.org Fri Jun 27 00:30:12 2008 From: quozl at us.netrek.org (James Cameron) Date: Fri, 27 Jun 2008 15:30:12 +1000 Subject: [netrek-dev] darcs patch: Client and Server packets transition to using metaclas... In-Reply-To: <20080626065421.4E7D31180703@ip-10-233-11-43.local> References: <20080626065421.4E7D31180703@ip-10-233-11-43.local> Message-ID: <20080627053012.GA16671@us.netrek.org> Taken. -- James Cameron mailto:quozl at us.netrek.org http://quozl.netrek.org/ From bogus@does.not.exist.com Mon Jun 16 10:37:07 2008 From: bogus@does.not.exist.com () Date: Mon, 16 Jun 2008 15:37:07 -0000 Subject: No subject Message-ID: via the "hold down torp key and move mouse" technique, but for the traditional 1 click/keypress per torp method it's really quite hard to notice due to limitation on my human reflexes. Server already limits to 1 torp request per server update (guess this was anti-borg code?). I don't mind changing the server to limit it to 10 torps/second, as long as it isn't going to make players feel they are "losing" torp request packets because the server is ignoring them because they can click too fast. It would also be nice if pickled was at more than 10 updates/second. Bill