> >]<A HREF="ftp://ftp.secnet.com/pub/patches/radius.patch">ftp://ftp.secnet.com/pub/patches/radius.patch</A> > > Has anyone confirmed that this patch works? it didn't apply properly, i had to do most of the fixes manually. doing it by hand forced me to check it a little more thoroughly. here's a two things i noticed: 1) there's a bug in function knowclient (already reported to the list). hostname and secret have to be char[128] instead of char*. what's more, i would do an sscanf(buffer,"%128s"...) to be on the safe side. 2) most of the changes are because of the function ip_hostname() in util.c is not checking the bounds. i don't really get it why the patch doesn't fix the problem at its source by modifying the function itself, but rather checks the return value after every call. wouldn't it be easier and better to do: in util.c (function ip_hostname) if (hp == 0) { ipaddr2str(hstname, ipaddr); return(hstname); } - return(hp->h_name); + else { + strncpy(hstname,hp->h_name,128); + hstname[127]='\0'; + return(hstname); + } i'd say, this solves the problem once and for good. or did i miss something ? cheers -wesi ---- Daniel Wesemann System & Network Engineer <A HREF="mailto:wesi@siemens.ch">mailto:wesi@siemens.ch</A> Siemens Switzerland <A HREF="http://www.siemens.ch">http://www.siemens.ch</A> ++ Ascend Users Mailing List ++ To unsubscribe: send unsubscribe to ascend-users-request@bungi.com To get FAQ'd: <<A HREF="http://www.nealis.net/ascend/faq">http://www.nealis.net/ascend/faq</A>> </PRE> <!--X-MsgBody-End--> <!--X-Follow-Ups--> <!--X-Follow-Ups-End--> <!--X-References--> <HR> <STRONG>References</STRONG>: <UL> <LI><STRONG><A HREF="msg11881.html">Re: (ASCEND) SNI-22: RADIUS Advisory (fwd)</A></STRONG></LI> <UL> <LI><EM>From</EM>: Jamie Penner <jpenner@nisa.net></LI> </UL> </UL> <!--X-References-End--> <!--X-BotPNI--> <HR> <UL> <LI>Prev by Date: <STRONG><A HREF="msg11898.html">Re: (ASCEND) SNI-22: RADIUS Advisory (fwd)</A></STRONG> </LI> <LI>Next by Date: <STRONG><A HREF="msg11896.html">Re: (ASCEND) Not a usually question</A></STRONG> </LI> <LI>Prev by thread: <STRONG><A HREF="msg11898.html">Re: (ASCEND) SNI-22: RADIUS Advisory (fwd)</A></STRONG> </LI> <LI>Next by thread: <STRONG><A HREF="msg11755.html">(ASCEND) Pipeline 5.1A with firewall</A></STRONG> </LI> <LI>Index(es): <UL> <LI><A HREF="maillist.html#11897"><STRONG>Main</STRONG></A></LI> <LI><A HREF="thrd281.html#11897"><STRONG>Thread</STRONG></A></LI> </UL> </LI> </UL> <!--X-BotPNI-End--> <!--X-User-Footer--> <!--X-User-Footer-End--> </BODY> </HTML>