Re: CF: "pickup all" seems to give me "pickup all and stop"

["Mark Wedel" <mark@icp.siemens.com>]

On Dec 3, 10:24pm, Maciej Kalisiak wrote:
> Subject: Re: CF: "pickup all" seems to give me "pickup all and stop"
> Tero Kivinen writes:
>  > Just use the "pickup all and stop", and it will pickup all and
>  > continue...
>
> Yep, you're right, thanks (somehow the logic here cracks me up; should
> have tried it myself).
>
> Looking at the code it is hard to say where the fix goes, since the
> mode is stored internally as a number (instead of a constant such as
> PICK_UP_ALL_STOP), and hence carries no intrinsic meaning. Either the
> order of the two options in the client needs to be rearranged or, in
> the server directory, in "player.c", about line 856, change:
>
>                 return (op->contr->mode != 4 ? 1 : 0);
>
> to
>
> 		return (op->contr->mode != 5 ? 1 : 0);
>
> I think it's easier from the client side; better not to change server
> behaviour if it's not necessary. David?

 Note that pickup mode 4 (old server and client for that matter) was always the
pickup all mode.  If the client is sending mode 5, then it is getting expected
behaviour.

 Pickup is one of the commands that actually has help for it:

'pickup' changes how you pick up items when you step on them.
to pickup an item manually, use the ',' key.

Mode 0: Don't pick up items.
Mode 1: Pick up one item
Mode 2: Pickup up one item and stop
Mode 3: Stop before picking up items
Mode 4: Pick up all items
Mode 5: Pick up all items and stop
Mode 6: Pick up all magical items
Mode 7: Pick up all coins and gems

Modes above 7: Pickup items with
a value density greater than the pickup mode.

Value density is value in gold/weight in kilograms.

The value in gold is what the item is worth if you
sold it in the shop.

Goldcoins have a value density of 66,

Density 10 will pickup silver, gold,
rings, wands, books, and scrolls.
Artifacts are also picked up.


-- 

-- Mark Wedel
mark@pyramid.com
-
[you can put yourself on the announcement list only or unsubscribe altogether
by sending an email stating your wishes to crossfire-request@ifi.uio.no]