Crossfire Archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: CF: patch to server/apply.c to get "marked" item identified first




Code using numbers with unspecified meanings is of very poor style.
Should use #define to give a name indicating the meaning of the value
so that other can read the code instead of having to know what 1 and 2
mean for these routines.

Lines not using defines where extremely highly recommended:
+       success=1;
+       if (!check_altar_sacrifice(altar)) success|=0x02;
+       success=2;
!       if (success & 0x02)
!     if (! (success & 0x01)) new_draw_info(NDI_UNIQUE, 0,pl,"You have nothing that needs identifying");

							sdw
-
[you can put yourself on the announcement list only or unsubscribe altogether
by sending an email stating your wishes to crossfire-request@ifi.uio.no]